Repository navigation
Conversation
Collaborator
|
Thanks for your PR. I think we'll get rid of the dependency altogether, see #2474 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fix the deprecation warning from the
ActiveSupport::Configurablemodule.What approach did you choose and why?
As I understand it, the
ViewComponent::Configurablemodule isn't used by the view_component gem and I don't know the original reason for its inclusion. Instead of completely removing the dependency on theActiveSupport::Configurablemodule, I've isolated its inclusion to only theViewComponent::Configurable.